issues: 35762823

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
35762823 MDExOlB1bGxSZXF1ZXN0MTcxNTgzOTg= 163 BUG: fix encoding issues (array indexing now resets encoding) 1217238 closed 0   650893 4 2014-06-16T01:29:22Z 2014-06-17T07:28:45Z 2014-06-16T04:52:43Z MEMBER   0 pydata/xarray/pulls/163

Fixes #156, #157

To elaborate on the changes: 1. When an array is indexed, its encoding will be reset. This takes care of the invalid chunksize issue. More generally, this seems like the right choice because it's not clear that the right encoding will be the same after slicing an array, anyways. 2. If an array has encoding['dtype'] = np.dtype('S1') (e.g., it was originally encoded in characters), it will be stacked up to be saved as a character array, even if it's being saved to a NetCDF4 file. Previously, the array would be cast to 'S1' without stacking, which would result in silent loss of data.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/163/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables