issues: 35760380
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 35760380 | MDExOlB1bGxSZXF1ZXN0MTcxNTcyMjI= | 162 | Change np.isnan to pd.isnull in conventions.py to handle _FillValue = '' | 4194485 | closed | 0 | 1 | 2014-06-15T23:10:29Z | 2014-06-15T23:16:48Z | 2014-06-15T23:16:35Z | NONE | 0 | pydata/xarray/pulls/162 | At a number of spots in conventions.py, np.isnan was being used to check possible fill values. However, np.isnan is not implemented for string types. So, I've replaced np.isnan with pd.isnull. Alas, I haven't been able to update the tests to cover _FillValue = '', because doing so would involve significant changes throughout the code base. |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/162/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |