issues: 346294369

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
346294369 MDExOlB1bGxSZXF1ZXN0MjA1MTkyOTE2 2330 Supplying a dataset to the dataset constructor 5635139 closed 0     12 2018-07-31T17:51:45Z 2018-09-25T21:00:17Z 2018-09-25T21:00:12Z MEMBER   0 pydata/xarray/pulls/2330
  • [x] Closes https://github.com/pydata/xarray/issues/2056
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)

  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API

  • Do we want to raise if coords / attrs are passed in addition to a Dataset? Do we want to warn for a couple versions first?

  • Is this the best way to implement this? Do we want a consistent method to "make this object a shallow copy of the object that's been passed in"?
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2330/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables