issues: 345322908

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
345322908 MDExOlB1bGxSZXF1ZXN0MjA0NTA2MTg2 2322 BUG: modify behavior of Dataset.filter_by_attrs to match netCDF4.Data… 868027 closed 0     5 2018-07-27T18:25:42Z 2018-08-28T01:48:00Z 2018-08-28T01:21:20Z CONTRIBUTOR   0 pydata/xarray/pulls/2322

Here is my fix for #2315 which matches the behavior of Dataset.filter_by_attrs to be that of its netCDF4 inspiration. I followed the pattern seen in the netCDF4 library which set a boolean flag while looping over attributes and short circuits the loop if any test returns false. Only if all the key=value/callable tests pass is the variable added to the output.

  • [x] Closes #2315
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2322/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables