issues: 324759261

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
324759261 MDExOlB1bGxSZXF1ZXN0MTg5MjYzMjc3 2166 Fix string slice indexing for a length-1 CFTimeIndex 6628425 closed 0     1 2018-05-21T01:04:01Z 2018-05-21T10:51:16Z 2018-05-21T08:02:35Z MEMBER   0 pydata/xarray/pulls/2166
  • [x] Closes #2165
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

The issue is that both is_monotonic_decreasing and is_monotonic_increasing return True for a length-1 index; therefore an additional check is needed to make sure the length of the index is greater than 1 in CFTimeIndex._maybe_cast_slice_bound. This is similar to how things are done in DatetimeIndex._maybe_cast_slice_bound in pandas.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2166/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables