issues: 319419699

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
319419699 MDU6SXNzdWUzMTk0MTk2OTk= 2099 Dataset.update wrongly handles the coordinate 6815844 closed 0     0 2018-05-02T06:04:02Z 2018-05-02T21:59:34Z 2018-05-02T21:59:34Z MEMBER      

Code Sample, a copy-pastable example if possible

I noticed a bug introduced by #2087 (my PR)

```python import xarray as xr

ds = xr.Dataset({'var': ('x', [1, 2, 3])}, coords={'x': [0, 1, 2], 'z1': ('x', [1, 2, 3]), 'z2': ('x', [1, 2, 3])})

ds['var'] = ds['var'] * 2 ``` It claims a ValueError.

Problem description

https://github.com/pydata/xarray/blob/0cc64a08c672e6361d05acea3fea9f34308b62ed/xarray/core/merge.py#L564

Here should be python other[k] = obj.drop(coord_names) not python other[k] = obj.drop(*coord_names)

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/2099/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables