issues: 303103716

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
303103716 MDExOlB1bGxSZXF1ZXN0MTczNDU1NzQz 1972 Starter property-based test suite 12229877 closed 0     15 2018-03-07T13:45:07Z 2018-03-20T12:51:28Z 2018-03-20T12:40:12Z CONTRIBUTOR   0 pydata/xarray/pulls/1972
  • [x] Closes #1846
  • [x] Tests added - you bet
  • [x] Tests passed - well, the code under test hasn't changed...

This is a small property-based test suite, to give two examples of the kinds of tests that we could write for Xarray using Hypothesis.

  1. For any array, encoding and decoding it with a CF coder outputs an identical array. As you would hope, these tests pass.
  2. For any 2D array, you can call the 2D plotting methods without raising an exception. Alas, this is not the case, and Hypothesis will show you the failing inputs (and matplotlib-related tracebacks) to prove it. (Contributing a very small feature to matplotlib was shockingly painful, so I'm not planning to take a similar suite upstream myself unless something changes)

Things that I would like to know:

  • Have I build-wrangled something reasonable here?
  • Will anyone else contribute property-based tests? I'm happy to help people debug or work out how to test something, but I simply don't have the time to write another test suite for free.
  • Is this something you want?
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1972/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables