issues: 301856320

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
301856320 MDExOlB1bGxSZXF1ZXN0MTcyNTY4Njcx 1953 Fix maybe_promote 1997005 closed 0     3 2018-03-02T18:11:49Z 2018-08-20T16:35:50Z 2018-08-20T16:31:16Z CONTRIBUTOR   0 pydata/xarray/pulls/1953

With tests for every possible dtype:

(numpy docs say biufcmMOSUV only)

python for letter in string.ascii_letters: try: print(letter, np.dtype(letter)) except TypeError as exc: pass

  • [x] Closes #1952
  • [x] Tests added (for all bug fixes or enhancements)
  • [x] Tests passed (for all non-documentation changes)
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1953/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables