issues: 295055292

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
295055292 MDExOlB1bGxSZXF1ZXN0MTY3NjMyMDY1 1893 Use correct dtype for RGB image alpha channel 12229877 closed 0     4 2018-02-07T09:00:33Z 2018-02-14T05:42:15Z 2018-02-12T22:12:13Z CONTRIBUTOR   0 pydata/xarray/pulls/1893
  • [x] Closes #1880
  • [x] Tests added (for all bug fixes or enhancements)
  • [ ] Tests passed (for all non-documentation changes)
  • [x] Fully documented (bugfix for earlier change, no additional note)

The cause of the bug in #1880 was that I had forgotten to specify the dtype when creating an alpha channel, and therefore concatenating it cast the all the data to float64. I've fixed that, corrected the alpha value for integer arrays, and avoided a pointless copy to save memory.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1893/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables