issues: 288322322
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 288322322 | MDExOlB1bGxSZXF1ZXN0MTYyNzc2ODAx | 1824 | Make `flake8 xarray` pass | 12229877 | closed | 0 | 3 | 2018-01-13T11:37:43Z | 2018-01-14T23:10:01Z | 2018-01-14T20:49:20Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/1824 | Closes #1741 by @mrocklin (who did most of the work I'm presenting here). I had an evening free, so I rebased the previous pull on master, fixed the conflicts, and then made everything pass with The single change any non-pedant will notice: Travis now fails if there is a flake8 warning anywhere. My experience in other projects is that this is the only way to actually keep flake8 passing - it's just unrealistic to expect perfect attention to detail from every contributor, but "make the build green before we merge" is widely understood 😄 |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/1824/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |