home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 269182902

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
269182902 MDExOlB1bGxSZXF1ZXN0MTQ5MjQ2NDQ5 1664 BUG: Added new names for pandas isna/notna unary functions 500246 closed 0     1 2017-10-27T17:38:54Z 2017-11-09T02:47:21Z 2017-11-09T02:47:21Z CONTRIBUTOR   0 pydata/xarray/pulls/1664

In pandas commit https://github.com/pandas-dev/pandas/commit/793020293ee1e5fa023f45c12943a4ac51cc23d isna and notna were added as aliases for isnull and notnull. Those need to be added to PANDAS_UNARY_FUNCTIONS for xarray datasets notnull to work. Closes #1663.

  • [ ] Closes #1663

Note: I'm not sure how to test for this, as I think existing tests should be already failing due to this. In fact, when I run nosetests on my system I get 123 skips, 29 errors and 2 failures, none of which are related to my addition, so there must be something wrong on my system.

I did not try the flake8 test and I think new documentation is exaggerated in this case.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1664/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 0.476ms · About: xarray-datasette