issues: 230566456

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
230566456 MDExOlB1bGxSZXF1ZXN0MTIxODk5MjA2 1421 Adding arbitrary object serialization 2941720 open 0     8 2017-05-23T01:59:37Z 2022-06-09T14:50:17Z   CONTRIBUTOR   0 pydata/xarray/pulls/1421

This adds support for object serialization using the netCDF4-python backend..

Minimum working (at least appears to..) example, no tests yet.

I added allow_object kwarg (rather than allow_pickle, no reason to firmly attach pickle to the api, could use something else for other backends).

This is now for:

  • to_netcdf
  • AbstractDataStore (a True value raises NotImplementedError for everything but NetCDF4DataStore)
  • cf_encoder which when True alters its behaviour to allow dtype('O') through.

NetCDF4DataStore handles this independently from the cf_encoder/decoder. The dtype support made it hard to decouple, plus I think object serialization is a backend dependent issue.

There's a lot of potential for refactoring, just pushed this to get opinions about whether this was a reasonable approach - I'm relatively new to open source, so would appreciate any constructive feedback/criticisms!

  • [ ] Closes #xxxx
  • [ ] Tests added / passed
  • [ ] Passes git diff upstream/master | flake8 --diff
  • [ ] Fully documented, including whats-new.rst for all changes and api.rst for new API

^ these will come later!

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1421/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables