issues: 229370997

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
229370997 MDExOlB1bGxSZXF1ZXN0MTIxMDcxMTA3 1412 Multiindex scalar coords, fixes #1408 6815844 closed 0     9 2017-05-17T14:25:50Z 2017-05-25T11:04:55Z 2017-05-25T11:04:55Z MEMBER   0 pydata/xarray/pulls/1412
  • [x] Closes #1408
  • [x] Tests added / passed
  • [x] Passes git diff upstream/master | flake8 --diff
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

To fix #1408, This modification works, but actually I do not fully satisfied yet. There are if statements in many places.

The major changes I made are 1. variable.__getitem__ now returns an OrderedDict if a single element is selected from MultiIndex. 2. indexing.remap_level_indexers also returns selected_dims which is a map from the original dimension to the selected dims which will be a scalar coordinate.

Change 1 keeps level-coordinates even after ds.isel(yx=0). Change 2 enables to track which levels are selected, then the selected levels are changed to a scalar coordinate.

I guess much smarter solution should exist. I would be happy if anyone gives me a comment.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1412/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables