issues: 2145890271
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2145890271 | PR_kwDOAMm_X85negFY | 8774 | Fixing issue #8770: Improved frequency parameter logic to set it to 'D' only if periods, start, or end are None. | 46948104 | closed | 0 | 11 | 2024-02-21T05:48:46Z | 2024-02-24T12:43:22Z | 2024-02-24T12:43:19Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/8774 | This Pull Request addresses the issue reported regarding the default setting of the frequency (freq) parameter in Xarray. Currently, the frequency is explicitly set to "D" by default, which may not always be appropriate behavior. The proposed improvement adjusts the logic to set the frequency to "D" only if any of the parameters (periods, start, or end) are None, providing more flexibility and aligning with expected behavior. Changes: Updated logic for setting the frequency parameter to consider periods, start, or end values. Added checks to ensure that the frequency is set to "D" only when necessary. Please review and provide feedback on the proposed changes. Any suggestions for further improvements are welcome.
|
{
"url": "https://api.github.com/repos/pydata/xarray/issues/8774/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |