home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 2123948734

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2123948734 PR_kwDOAMm_X85mT5_9 8719 Test formatting platform 45271239 closed 0     2 2024-02-07T21:41:23Z 2024-02-09T03:01:35Z 2024-02-09T03:01:35Z CONTRIBUTOR   0 pydata/xarray/pulls/8719

Follow up #8702 / https://github.com/pydata/xarray/pull/8702#issuecomment-1932851112

The goal is to remove the not elegant OS-dependant checks introduced during the testing of #8702

A simple way to do so is to use unsigned integer as dtypes for tests involving data array representations on multiple OSes. Indeed, this solves the issue of the default dtypes being not printed in the repr, with default dtyps varying according to the OS. The tests show that the concerned dtypes are int32 (for the Windows CI) and int64 (for Ubuntu and macOS CIs). Using uint64 should fix both the varying size and the varying numpy array repr.

~~- [ ] Closes #xxxx~~ - [x] Tests added ~~- [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst~~ ~~- [ ] New functions/methods are listed in api.rst~~

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8719/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 0 rows from issue in issue_comments
Powered by Datasette · Queries took 0.959ms · About: xarray-datasette