issues: 2116618415
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
2116618415 | PR_kwDOAMm_X85l7Cdb | 8698 | New alignment option: `join='strict'` | 45271239 | closed | 0 | 5 | 2024-02-03T17:58:43Z | 2024-02-25T09:09:37Z | 2024-02-25T09:09:37Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/8698 | Title: New alignment option:
MotiveThis PR is motivated by solving of the following issues:
The current PR does not solve the unexpected issue described in #8231 without a change in user-code. Indeed, in the tests written, it is shown that to get the said expected behavior, the user would have to use the new This may not be enough to fix #8231. If that isn't, I can split the PR into two, first one for adding the Technical DetailsI try to detail here my thought process. Please correct me if there is anything wrong. This is my first time digging into this core logic! Here is my understanding of the terms:
Input data for Scenario 1, tested in ```python ds1 = Dataset( coords={ "x_center": ("x_center", [1, 2, 3]), "x_outer": ("x_outer", [0.5, 1.5, 2.5, 3.5]), }, )
``` Input data for Scenario 2, tested in ```python ds1 = Dataset( data_vars={ "a": ("x_center", [1, 2, 3]), "b": ("x_outer", [0.5, 1.5, 2.5, 3.5]), }, )
``` Logic for non-indexed dimensions logic was working "as expected", as it relies on However, the logic for indexed dimensions was surprising as such an expected check on dimensions' sizes was not performed. A check exists in |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/8698/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |