issues: 2115733488

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
2115733488 PR_kwDOAMm_X85l4Aq8 8697 add open_datatree to xarray 479480 closed 0     18 2024-02-02T20:20:03Z 2024-02-14T23:41:03Z 2024-02-14T21:50:29Z CONTRIBUTOR   0 pydata/xarray/pulls/8697

Draft: I'd like to open this up and start a discussion on a couple of things.

Here is a first stab at adding open_datatree to the backend of xarray.

  1. ~~I'm not sure which tests to migrate/write with this change. The only datatree tests that have open_datatree are the ones in tests/test_io.py. While those (and all of the datatree tests) run and pass, they are still located in _datatree, and they don't seem to fit in the test_backends.py. I do see that Tom did a good job of naming the tests so that they would fit with the existing tests in many places.~~ Migrated tests over into xarray/tests/datatree once approved and merged can be added into the existing tests where appropriate (from Tom).
  2. I was able to open datatrees with each of the engines, netcdf4, h5netcdf and zarr.
  3. I haven't moved any documentation. I remember hearing that we could add it and mark it as experimental? Is that the correct way forward?

No check boxes checked yet. - [ ] Closes part of first bullet of https://github.com/pydata/xarray/issues/8572 - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst - [ ] New functions/methods are listed in api.rst

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8697/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     13221727 pull

Links from other tables