issues: 211323643

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
211323643 MDExOlB1bGxSZXF1ZXN0MTA4NzEwNjg5 1289 Added a support for Dataset.rolling. 6815844 closed 0     9 2017-03-02T08:40:03Z 2017-07-09T23:53:13Z 2017-03-31T03:10:45Z MEMBER   0 pydata/xarray/pulls/1289
  • [x] closes #859
  • [x] tests added / passed
  • [x] passes git diff upstream/master | flake8 --diff
  • [x] whatsnew entry

There seems to be two approaches to realize Dataset.rolling, 1. Apply rolling in each DataArrays and then combine them. 2. Apply Dataset directoly with some DataArrays that do not depend on dim kept aside, then merge them later.

I chose the latter approach to reuse existing Rolling object as much as possible, but it results in some duplicates in ImplementsRollingDatasetReduce. Any feedbacks and comments are very welcome.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1289/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables