issues: 1992942893

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1992942893 PR_kwDOAMm_X85fa-Sc 8450 Add keep_variables keyword to open_dataset() 48135565 open 0     2 2023-11-14T15:09:24Z 2023-11-17T08:27:39Z   FIRST_TIME_CONTRIBUTOR   0 pydata/xarray/pulls/8450

This is based on #895 by @tsupinie, following the suggestions on that PR made by @shoyer, but that was so old I decided it was best to do a completely new PR. XArray has changed quite a bit since then, so I had to make changes in several more files than the original PR did in order to get tests to pass.

I'm very new to working on XArray, and my approach here was to basically just mirror how the package handles drop_variables wherever that appears, with the necessary logical tweaks where appropriate. As such I've possibly touched something that shouldn't be (in particular I'm looking at xarray/backends/zarr.py and xarray/backends/common.py as places where I'm not quite sure if I've done things properly).

  • [ ] Closes #1754
  • [x] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8450/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables