issues: 198030158

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
198030158 MDExOlB1bGxSZXF1ZXN0OTk2NzE3Njk= 1191 Integer levels and vmin/vmax 10050469 closed 0     2 2016-12-29T16:10:22Z 2017-01-03T09:50:14Z 2017-01-03T09:50:14Z MEMBER   0 pydata/xarray/pulls/1191

Follow-up to https://github.com/pydata/xarray/pull/1171#issuecomment-269556898

From the new docstring:

levels : int or list-like object, optional Split the colormap (cmap) into discrete color intervals. If an integer is provided, "nice" levels are chosen based on the data range: this can imply that the final number of levels is not exactly the expected one. Setting ``vmin`` and/or ``vmax`` with ``levels=N`` is equivalent to setting ``levels=np.linspace(vmin, vmax, N)``.

The logic overhead is quite simple, which is an argument in favor of this simple solution. It is consistent with mpl, as long as neither vmin or vmax are set.

It might change the outcome of some existing plots, though. Should I mention this in the "Breaking changes" section too?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1191/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables