issues: 1975173557
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1975173557 | PR_kwDOAMm_X85ee4vk | 8406 | Add getitem to array protocol | 14371165 | closed | 0 | 0 | 2023-11-02T23:02:48Z | 2023-12-12T20:54:00Z | 2023-12-12T20:44:11Z | MEMBER | 0 | pydata/xarray/pulls/8406 | Currently using getitem is not allowed for either a arrayfunction or arrayapi according to the type hints. Add support for it. Issues found in #8344 as more and more typing was added. But getitem is used in main as well which should fail, but manages to pass due to lack of type hints: https://github.com/pydata/xarray/blob/9acc411bc7e99e61269eadf77e96b9ddd40aec9e/xarray/namedarray/core.py#L792 Notes
* mypy will now complain for https://github.com/numpy/numpy/pull/25022 https://github.com/data-apis/array-api/pull/687 |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/8406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |