issues: 1960287586
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1960287586 | I_kwDOAMm_X850151i | 8370 | Testing NamedArray and Variable | 14077947 | closed | 0 | 2 | 2023-10-25T00:18:50Z | 2023-11-28T15:11:27Z | 2023-11-28T15:11:27Z | CONTRIBUTOR | Starting a new issue to continue the discussion from https://github.com/pydata/xarray/issues/8244 about the test structure for NamedArray (xref https://github.com/pydata/xarray/issues/8238).
It should work to use @andersy005 when do you think would be the best time to test out this method for migrating tests? I could try it out anytime and don't see many downsides to testing while namedarray is still coupled with xarray. ```python namedarray/testing.pyimport numpy as np class NamedArrayTestSuite: @pytest.fixture def target(self): """Fixture that needs to be re-declared""" assert 0
``` ```python namedarray/tests/test_namedarray.pyfrom namedarray.testing import NamedArrayTestSuite from namedarray import NamedArray class TestNamedArray(NamedArrayTestSuite):
``` ```python xarray/tests/test_variable.pyfrom namedarray.testing import NamedArrayTestSuite from xarray import Variable class TestVariable(NamedArrayTestSuite):
``` |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/8370/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | 13221727 | issue |