home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 194095134

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
194095134 MDExOlB1bGxSZXF1ZXN0OTY5NTYyOTQ= 1155 RTD: fix savefig dir creation 10050469 closed 0     1 2016-12-07T16:21:01Z 2016-12-07T16:53:07Z 2016-12-07T16:38:03Z MEMBER   0 pydata/xarray/pulls/1155

I've had a hard time finding out what was going on with missing RTD plots since we updated the packages until I came across this: https://github.com/ipython/ipython/issues/8733

The proposed fix creates the @savefig directory if not there. It works locally but I'm not sure if it will work on RTD (they might use a custom build directory).

The other changes are minor tweaks to remove some build warnings and/or making use of the latest sphinx Makefile. I also removed a part of the conf.py which I think is not needed anymore.

@shoyer do you remember what the inspect.findsource monkeypatch was good for?

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1155/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 1 row from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 0.641ms · About: xarray-datasette