issues: 1924487457
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1924487457 | PR_kwDOAMm_X85bzzXe | 8268 | Add extra overload for to_netcdf | 548266 | closed | 0 | 3 | 2023-10-03T16:15:10Z | 2023-12-04T07:04:39Z | 2023-12-03T18:24:54Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/8268 | The current signature does not match with pyright if a non-literal bool is passed. This fixes type checking of code like this: ```python import xarray as xr def myfunc(compute: bool) -> None: ds = xr.Dataset() ds.to_netcdf(path="myfile.nc", compute=compute) ``` with pyright. See https://github.com/microsoft/pyright/issues/6069 for context. |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/8268/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |