issues: 189817033

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
189817033 MDExOlB1bGxSZXF1ZXN0OTQwMzMyNzg= 1128 Remove caching logic from xarray.Variable 1217238 closed 0     19 2016-11-16T19:29:32Z 2016-12-09T09:08:48Z 2016-11-30T23:44:48Z MEMBER   0 pydata/xarray/pulls/1128

This is a follow-up to generalize the changes from #1024:

  • Caching and copy-on-write behavior has been moved to separate array classes that are explicitly used in open_dataset to wrap arrays loaded from disk (if cache=True).
  • Dask specific logic has been removed from the caching/loading logic on xarray.Variable.
  • Pickle no longer caches automatically under any circumstances.
  • DataStore objects are now pickleable. This makes it feasible to use xarray's IO with dask-distributed or multi-processing.

~~Still needs tests for the cache argument to open_dataset, but everything else seems to be working.~~

@crusaderky @kynan please review

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/1128/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables