issues: 1883718333

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1883718333 I_kwDOAMm_X85wR0K9 8150 assign_coords changed its behaviour from v2023.07.0 to v2023.08.0 61285767 closed 0     2 2023-09-06T10:29:53Z 2023-09-06T21:04:46Z 2023-09-06T21:04:45Z NONE      

What happened?

assign_coords changed its behaviour in v2023.08.0 now, when trying to assign an existing coord, it doesn't do anything...

I was using it to reorder some xarray.DataArrays, keeping the coordinate names, f.e.:

python import xarray as xr a = xr.DataArray([1, 2, 3], {'dim': ['A', 'B', 'C']}) new_order = [1, 0, 2] a[new_order].assign_coords(a.coords)

returns <xarray.DataArray (dim: 3)> array([2, 1, 3]) Coordinates: * dim (dim) <U1 'B' 'A' 'C' I also tried to use a copy of the original coords a[new_order].assign_coords(a.coords.copy()), but it didn't work.

The behaviour is confusing and may lead to wrong results.

What did you expect to happen?

The same code in version v2023.07.0 returned the coordinates as defined and only changed the position of the values: <xarray.DataArray (dim: 3)> array([2, 1, 3]) Coordinates: * dim (dim) <U1 'A' 'B' 'C'

It also works properly passing a dictionary instead of the coords object, a[new_order].assign_coords({'dim': ['A', 'B', 'C']}).

Minimal Complete Verifiable Example

Python import xarray as xr a = xr.DataArray([1, 2, 3], {'dim': ['A', 'B', 'C']}) new_order = [1, 0, 2] a[new_order].assign_coords(a.coords)

MVCE confirmation

  • [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • [X] Complete example — the example is self-contained, including all data and the text of any traceback.
  • [X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

No response

Anything else we need to know?

No response

Environment

INSTALLED VERSIONS ------------------ commit: None python: 3.11.0 | packaged by conda-forge | (main, Jan 14 2023, 12:27:40) [GCC 11.3.0] python-bits: 64 OS: Linux OS-release: 5.15.0-83-generic machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_GB.UTF-8 LOCALE: ('en_GB', 'UTF-8') libhdf5: 1.10.4 libnetcdf: 4.7.3 xarray: 2023.8.0 pandas: 2.1.0 numpy: 1.23.5 scipy: 1.10.0 netCDF4: 1.6.0 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.6.2 nc_time_axis: None PseudoNetCDF: None iris: None bottleneck: None dask: 2023.1.1 distributed: 2023.1.1 matplotlib: None cartopy: None seaborn: None numbagg: None fsspec: 2023.1.0 cupy: None pint: None sparse: None flox: None numpy_groupies: None setuptools: 66.1.1 pip: 22.3.1 conda: None pytest: 7.2.1 mypy: None IPython: None sphinx: None 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8150/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables