home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 1879864306

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1879864306 PR_kwDOAMm_X85ZdmTF 8142 Dirty workaround for mypy 1.5 error 4160723 closed 0     8 2023-09-04T09:21:18Z 2023-09-07T16:04:55Z 2023-09-07T08:21:12Z MEMBER   0 pydata/xarray/pulls/8142

I wanted to fix the following error with mypy 1.5:

xarray/core/dataset.py:505: error: Definition of "__eq__" in base class "DatasetOpsMixin" is incompatible with definition in base class "Mapping" [misc]

Which looks similar to https://github.com/python/mypy/issues/9319. It is weird that here it worked with mypy versions < 1.5, though.

I don't know if there is a better fix, but I thought that redefining __eq__ in Dataset would be a bit less dirty workaround than adding type: ignore in the class declaration.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8142/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 0 rows from issue in issue_comments
Powered by Datasette · Queries took 0.55ms · About: xarray-datasette