issues: 1874148181
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1874148181 | I_kwDOAMm_X85vtTtV | 8123 | `.rolling_exp` arguments could be clearer | 5635139 | open | 0 | 6 | 2023-08-30T18:09:04Z | 2023-09-01T00:25:08Z | MEMBER | Is your feature request related to a problem?Currently we call
But we also have different window types, and this makes it a bit incongruent:
...since the Describe the solution you'd likeOne option would be:
We pass a dict if we want a non-standard window type — so the value is attached to its type. We could still have the original form for Describe alternatives you've consideredNo response Additional context(I realize I wrote this originally, all criticism directed at me! This is based on feedback from a colleague, which on reflection I agree with.) Unless anyone disagrees, I'll try and do this soon-ish™ |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/8123/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | issue |