home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 1827010471

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1827010471 I_kwDOAMm_X85s5fen 8029 ' ' at end of variable name causes to_netcdf() to crash 18679628 closed 0     6 2023-07-28T19:48:53Z 2023-08-14T16:15:40Z 2023-08-14T16:15:40Z NONE      

What happened?

If variable name ends in a ' ' (space) then to_netcdf crashes.

In my opinion - At least the error message could tell which variable name has the issue - If space at the end is not allowed, then could you rstrip everything - It works with scipy xarr.to_netcdf(newName, engine="scipy")

This is related to https://github.com/pydata/xarray/issues/7943

Our tool converts csv files to XARRAY. So these kind of errors need to self-heal, otherwise we have to feedback to the user and get them to change the csv file. Which would be frustrating for everyone

What did you expect to happen?

No response

Minimal Complete Verifiable Example

```Python with open('endSpace.csv','w') as f: f.write('''PASS ,temperature PASS, 10 FAIL, 20''')

import pandas as pd df = pd.read_csv('endSpace.csv') index = ['temperature'] df = df.set_index(index) xarr = df.to_xarray() xarr.to_netcdf("new.nc") ```

MVCE confirmation

  • [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • [X] Complete example — the example is self-contained, including all data and the text of any traceback.
  • [X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

Python Traceback (most recent call last): File "/Users/will/Documents/GitHub/czdashboard/old/coordNameBug.py", line 11, in <module> xarr.to_netcdf("new.nc") File "/opt/homebrew/lib/python3.11/site-packages/xarray/core/dataset.py", line 1911, in to_netcdf return to_netcdf( # type: ignore # mypy cannot resolve the overloads:( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/lib/python3.11/site-packages/xarray/backends/api.py", line 1217, in to_netcdf dump_to_store( File "/opt/homebrew/lib/python3.11/site-packages/xarray/backends/api.py", line 1264, in dump_to_store store.store(variables, attrs, check_encoding, writer, unlimited_dims=unlimited_dims) File "/opt/homebrew/lib/python3.11/site-packages/xarray/backends/common.py", line 271, in store self.set_variables( File "/opt/homebrew/lib/python3.11/site-packages/xarray/backends/common.py", line 309, in set_variables target, source = self.prepare_variable( ^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/lib/python3.11/site-packages/xarray/backends/netCDF4_.py", line 488, in prepare_variable nc4_var = self.ds.createVariable( ^^^^^^^^^^^^^^^^^^^^^^^ File "src/netCDF4/_netCDF4.pyx", line 2945, in netCDF4._netCDF4.Dataset.createVariable File "src/netCDF4/_netCDF4.pyx", line 4164, in netCDF4._netCDF4.Variable.__init__ File "src/netCDF4/_netCDF4.pyx", line 2014, in netCDF4._netCDF4._ensure_nc_success RuntimeError: NetCDF: Name contains illegal characters

Anything else we need to know?

No response

Environment

commit : 2e218d10984e9919f0296931d92ea851c6a6faf5 python : 3.11.2.final.0 python-bits : 64 OS : Darwin OS-release : 22.5.0 Version : Darwin Kernel Version 22.5.0: Thu Jun 8 22:21:34 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T8112 machine : arm64 processor : arm byteorder : little LC_ALL : None LANG : en_US.UTF-8 LOCALE : en_US.UTF-8 pandas : 1.5.3 numpy : 1.24.2 pytz : 2023.3 dateutil : 2.8.2 setuptools : 65.6.3 pip : 23.1.1 Cython : None pytest : None hypothesis : None sphinx : None blosc : None feather : None xlsxwriter : None lxml.etree : None html5lib : None pymysql : None psycopg2 : None jinja2 : 3.1.2 IPython : None pandas_datareader: None bs4 : None bottleneck : None brotli : None fastparquet : None fsspec : 2023.3.0 gcsfs : None matplotlib : None numba : None numexpr : None odfpy : None openpyxl : None pandas_gbq : None pyarrow : None pyreadstat : None pyxlsb : None s3fs : None scipy : 1.10.1 snappy : None sqlalchemy : None tables : None tabulate : None xarray : 2023.2.0 xlrd : None xlwt : None zstandard : None tzdata : None
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8029/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed 13221727 issue

Links from other tables

  • 2 rows from issues_id in issues_labels
  • 0 rows from issue in issue_comments
Powered by Datasette · Queries took 0.859ms · About: xarray-datasette