issues: 1760393016

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1760393016 PR_kwDOAMm_X85TLZof 7923 Fix check for chunk_store in zarr backend 50025784 closed 0     5 2023-06-16T11:00:45Z 2023-06-23T18:50:17Z 2023-06-23T18:50:14Z CONTRIBUTOR   0 pydata/xarray/pulls/7923

Zarr stores implement the __len__ method and thus checking if a store is truthy returns if the store is non-empty, not if the chunk_store variable is still None. With this fix, empty stores can be passed as chunk_store to the to_zarr(...) method and will actually be used.

  • [ ] Closes #xxxx
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7923/reactions",
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables