issues: 1726529405

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1726529405 PR_kwDOAMm_X85RYfGo 7875 defer to `numpy` for the expected result 14808389 closed 0     1 2023-05-25T21:48:18Z 2023-05-27T19:53:08Z 2023-05-27T19:53:07Z MEMBER   0 pydata/xarray/pulls/7875

numpy has recently changed the result of np.cos(0) by a very small value, which makes our tests break.

I'm not really sure what the best fix is, so I split the changes into two parts: the first commit uses python xr.testing.assert_allclose(a + 1, np.cos(a)) to test the result, while the second commit uses python expected = xr.full_like(a, fill_value=np.cos(0), dtype=float) actual = np.cos(a) xr.testing.assert_identical(actual, expected)

  • [x] towards #7707
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7875/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables