issues: 1725525753

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1725525753 PR_kwDOAMm_X85RVEiR 7874 Changed duck typing exception to: (ImportError, AttributeError) 3092444 closed 0     2 2023-05-25T10:15:39Z 2023-05-26T16:19:39Z 2023-05-26T16:19:35Z CONTRIBUTOR   0 pydata/xarray/pulls/7874
  • [x] closes #7870

As described in issue #7870, there is a name-collision with the astrophysics package pint-pulsar, which is used to do high-precision pulsar timing. That other package would get imported as pint, and an AttributeError is thrown because that imported package is not the expected package.

By generalizing the duck typing exception to catch an ImportError and an AttributeError, we catch such name-collisions. It fits the idea and goal of duck typing.

This PR is a single-line change

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7874/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables