issues: 1676309093

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1676309093 PR_kwDOAMm_X85Ovv30 7771 implement scale_factor/add_offset CF conformance test, add and align tests 5821660 closed 0     3 2023-04-20T09:03:06Z 2023-11-17T20:59:38Z 2023-11-17T20:59:38Z MEMBER   1 pydata/xarray/pulls/7771
  • [ ] Closes #xxxx
  • [x] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

This is adding conformance tests for scale_factor/add_offset/dtype when encoding/decoding cf packed data with https://github.com/pydata/xarray/blob/c75ac8b7ab33be95f74d9e6f10b8173c68828751/xarray/coding/variables.py#L217. This doesn't include tests for _FillValue/missing_value/valid_range etc. which need a separate test.

The idea behind is two-fold:

  • be strict when encoding to only write CF conforming data, raise Errors if non-conforming
  • be liberal when decoding, but issue warnings

This is another step to move forward to finally fix issues like #2304 and a bunch more.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7771/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables