issues: 1512708767

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1512708767 I_kwDOAMm_X85aKhqf 7405 Test for variable name in coords True after xr.merge with compat="minimal" 12115839 closed 0     2 2022-12-28T11:39:48Z 2023-08-30T07:57:37Z 2023-08-30T07:57:37Z NONE      

What happened?

Merging two DataArrays with compat="minimal" drops the conflicting variable from coords but the test if that variable is in coords results to True even though the variable gets dropped.

What did you expect to happen?

The test should be False

Minimal Complete Verifiable Example

```Python import numpy as np import xarray as xr

da1 = xr.DataArray(np.zeros((2, 2)), dims=("y", "x"), name="1") c1 = ("y", ["1", "2"])
da1["c1"] = c1

da2 = xr.DataArray(np.zeros((2, 2)), dims=("y", "x"), name="2") c2 = ("y", ["3", "4"]) da2["c1"] = c2

xrds = xr.merge([da1, da2], compat="minimal")

"c1" in xrds.coords # results to True but should be False ```

MVCE confirmation

  • [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • [X] Complete example — the example is self-contained, including all data and the text of any traceback.
  • [X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

No response

Anything else we need to know?

No response

Environment

INSTALLED VERSIONS ------------------ commit: None python: 3.10.5 | packaged by conda-forge | (main, Jun 14 2022, 07:06:46) [GCC 10.3.0] python-bits: 64 OS: Linux OS-release: 5.10.0-1049-oem machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.12.1 libnetcdf: 4.8.1 xarray: 2022.12.0 pandas: 1.4.2 numpy: 1.22.3 scipy: 1.8.0 netCDF4: 1.5.8 pydap: None h5netcdf: 1.0.0 h5py: 3.6.0 Nio: None zarr: 2.11.3 cftime: 1.6.0 nc_time_axis: None PseudoNetCDF: None rasterio: 1.2.10 cfgrib: None iris: None bottleneck: 1.3.5 dask: 2022.05.0 distributed: 2022.5.0 matplotlib: 3.5.2 cartopy: 0.20.2 seaborn: None numbagg: None fsspec: 2022.8.2 cupy: None pint: 0.19.2 sparse: None flox: 0.6.5 numpy_groupies: 0.9.20 setuptools: 62.2.0 pip: 22.1 conda: None pytest: 7.1.2 mypy: None IPython: 8.3.0 sphinx: 4.5.0 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7405/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables