issues: 1489128898

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1489128898 PR_kwDOAMm_X85FCdPL 7373 Add `inclusive` argument to `cftime_range` and `date_range` and deprecate `closed` argument 6628425 closed 0     4 2022-12-10T23:40:47Z 2023-02-06T17:51:47Z 2023-02-06T17:51:46Z MEMBER   0 pydata/xarray/pulls/7373

Following pandas, this PR adds an inclusive argument to xarray.cftime_range and xarray.date_range and deprecates the closed argument. Pandas will be removing the closed argument soon in their date_range implementation, but we will continue supporting it to allow for our own deprecation cycle.

I think we may also need to update our minimum pandas version to 1.4 for this, since earlier versions of pandas do not support the inclusive argument.

  • [x] Closes #6985
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7373/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables