issues: 1464905814

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1464905814 I_kwDOAMm_X85XULBW 7322 Doctests failing 43316012 closed 0     4 2022-11-25T20:20:29Z 2022-11-28T19:31:04Z 2022-11-28T19:31:04Z COLLABORATOR      

What is your issue?

It seems that some update in urllib3 causes our doctests to fail.

The reason seems to be that botocore uses an interesting construction to import deprecated urllib3 things: python try: # pyopenssl will be removed in urllib3 2.0, we'll fall back to ssl_ at that point. # This can be removed once our urllib3 floor is raised to >= 2.0. with warnings.catch_warnings(): warnings.simplefilter("ignore", category=DeprecationWarning) # Always import the original SSLContext, even if it has been patched from urllib3.contrib.pyopenssl import ( orig_util_SSLContext as SSLContext, ) except ImportError: from urllib3.util.ssl_ import

I assume that this fails because we use -Werror which translates the warning into an error which then is not ignored...

Not sure if this is an issue with botocore or we have to catch this?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7322/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables