issues: 1461231016

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1461231016 I_kwDOAMm_X85XGJ2o 7312 polyval doesn't bind the output type 25172489 closed 0     3 2022-11-23T07:55:45Z 2022-11-26T15:42:52Z 2022-11-26T15:42:52Z NONE      

What happened?

We recently updated our package requirements to current xarray, and while some typing things got better for us, xarray.polyval seems to not allow mypy to correctly infer its output type.

What did you expect to happen?

Output type should depend on the input types.

Minimal Complete Verifiable Example

```Python from future import annotations

import numpy as np import xarray as xr

coeffs = xr.DataArray([1, 1]) xvals = xr.DataArray(np.arange(10))

result = xr.polyval(xvals, coeffs=coeffs) reveal_type(result) ```

MVCE confirmation

  • [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • [X] Complete example — the example is self-contained, including all data and the text of any traceback.
  • [ ] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

Python test.py:11: note: Revealed type is "Union[xarray.core.dataset.Dataset, xarray.core.dataarray.DataArray]"

Anything else we need to know?

No response

Environment

INSTALLED VERSIONS ------------------ commit: None python: 3.9.10 (main, Mar 15 2022, 15:56:56) [GCC 7.5.0] python-bits: 64 OS: Linux OS-release: 3.10.0-1160.49.1.el7.x86_64 machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.12.2 libnetcdf: 4.9.0 xarray: 2022.11.0 pandas: 1.5.1 numpy: 1.23.5 scipy: 1.9.3 netCDF4: 1.6.2 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.6.2 nc_time_axis: None PseudoNetCDF: None rasterio: None cfgrib: None iris: None bottleneck: None dask: None distributed: None matplotlib: 3.6.2 cartopy: None seaborn: None numbagg: None fsspec: None cupy: None pint: None sparse: None flox: None numpy_groupies: None setuptools: 65.6.0 pip: 22.3.1 conda: None pytest: 7.2.0 IPython: 8.6.0 sphinx: None 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7312/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables