home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 1381294181

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1381294181 I_kwDOAMm_X85SVOBl 7062 Rolling mean on dask array does not preserve dtype 39069044 closed 0     2 2022-09-21T17:55:30Z 2022-09-22T22:06:09Z 2022-09-22T22:06:09Z CONTRIBUTOR      

What happened?

Calling rolling().mean() on a dask-backed array sometimes outputs a different dtype than with a numpy backed array, for example with a float32 input. This is due to the optimized _mean function introduced in #4915.

What did you expect to happen?

This is a simple enough operation that if you start with float32 I would expect to get float32 back.

Minimal Complete Verifiable Example

```Python

import xarray as xr da = xr.DataArray([1,2,3], coords={'x':[1,2,3]}).astype('float32') da.rolling(x=3, min_periods=1).mean().dtype dtype('float32') da.chunk({'x':1}).rolling(x=3, min_periods=1).mean().dtype dtype('float64') ```

MVCE confirmation

  • [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray.
  • [X] Complete example — the example is self-contained, including all data and the text of any traceback.
  • [X] Verifiable example — the example copy & pastes into an IPython prompt or Binder notebook, returning the result.
  • [X] New issue — a search of GitHub Issues suggests this is not a duplicate.

Relevant log output

No response

Anything else we need to know?

5877 is somewhat related.

Environment

INSTALLED VERSIONS ------------------ commit: e6791852aa7ec0b126048b0986e205e158ab9601 python: 3.8.13 | packaged by conda-forge | (default, Mar 25 2022, 06:04:10) [GCC 10.3.0] python-bits: 64 OS: Linux OS-release: 5.15.0-46-generic machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.12.1 libnetcdf: 4.8.1 xarray: 2022.6.1.dev63+ge6791852.d20220921 pandas: 1.4.2 numpy: 1.21.6 scipy: 1.8.1 netCDF4: 1.5.8 pydap: installed h5netcdf: 1.0.2 h5py: 3.6.0 Nio: None zarr: 2.12.0 cftime: 1.6.0 nc_time_axis: 1.4.1 PseudoNetCDF: 3.2.2 rasterio: 1.2.10 cfgrib: 0.9.10.1 iris: 3.2.1 bottleneck: 1.3.4 dask: 2022.04.1 distributed: 2022.4.1 matplotlib: 3.5.2 cartopy: 0.20.2 seaborn: 0.11.2 numbagg: 0.2.1 fsspec: 2022.8.2 cupy: None pint: 0.19.2 sparse: 0.13.0 flox: 0.5.9 numpy_groupies: 0.9.19 setuptools: 62.0.0 pip: 22.2.2 conda: None pytest: 7.1.3 IPython: None sphinx: None
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7062/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed 13221727 issue

Links from other tables

  • 2 rows from issues_id in issues_labels
  • 2 rows from issue in issue_comments
Powered by Datasette · Queries took 6.216ms · About: xarray-datasette