issues: 1370340170

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1370340170 PR_kwDOAMm_X84-zpR- 7022 Preserve all attrs with GroupBy by default. 2448579 closed 0     0 2022-09-12T18:26:47Z 2022-10-18T19:15:21Z 2022-09-13T15:30:29Z MEMBER   0 pydata/xarray/pulls/7022

Closes #7012

When use_flox=False, we pass keep_attrs=None to Data*.reduce. This ends up delete Dataset and DataArray level attrs but preserves coordinate variable attrs. We now set the default to True always to match the default behaviour of apply_ufunc used by flox.xarray.xarray_reduce.

  • [x] Closes #7012
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7022/reactions",
    "total_count": 3,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
     13221727 pull

Links from other tables