issues: 1358247997

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1358247997 PR_kwDOAMm_X84-Lgp- 6974 Ensure encoding["source"] is available for a pathlib.Path object 15375218 closed 0     3 2022-09-01T04:52:42Z 2023-03-01T19:12:12Z 2022-09-13T07:17:39Z CONTRIBUTOR   0 pydata/xarray/pulls/6974

Closes #5888. At the moment if you pass a Path object, the source will not be encoded in, only if a string is passed in. Given there is already a function to handle this, _normalize_path, I've simplified the logic to just run that over the str/Path to ensure it is always encoded.

  • [x] Closes #5888
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

I'm not sure if this needs including in the whats-new.rst. I'm happy to add it if desired.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6974/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables