issues: 1309966595

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1309966595 PR_kwDOAMm_X847rKxS 6812 Improved CF decoding 145117 open 0     7 2022-07-19T19:44:27Z 2023-04-01T15:26:04Z   CONTRIBUTOR   0 pydata/xarray/pulls/6812
  • [X] Closes #2304 - but only for my specific use case.
  • [x] Tests added

The comments above this line state, "so we just use a float64" but then it returns np.float32. I assume the comments are correct. Changing this also fixes a bug I ran into.

Note that currently, _choose_float_dtype returns float32 if the data is float16 or float32, even if the scale_factor dtype is float64.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6812/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables