home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 1306543211

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1306543211 PR_kwDOAMm_X847f3yo 6792 Raise an error if you pass an invalid key in `chunks` 4806877 closed 0     3 2022-07-15T21:23:20Z 2022-08-02T15:57:50Z 2022-07-22T16:52:32Z CONTRIBUTOR   0 pydata/xarray/pulls/6792
  • [x] Tests added

This was a minor issue that came up at the Dask BOF. Currently if the key of chunks dict isn't included in the dims then it gets silently ignored. This PR makes xarray raise an error instead.

I'm not sure if this is the right place to put this change. So just let me know if it should go somewhere else.

I changed an existing test. I am pretty sure it was not intentionally using a key that isn't in the dims.

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6792/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 3 rows from issue in issue_comments
Powered by Datasette · Queries took 267.123ms · About: xarray-datasette