issues: 1207369905

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1207369905 I_kwDOAMm_X85H9wCx 6500 HTML repr dark/light themes in Sphinx Furo 11411331 closed 0     1 2022-04-18T19:26:47Z 2022-04-18T20:53:42Z 2022-04-18T20:53:42Z CONTRIBUTOR      

What is your issue?

The Xarray HTML repr assumes that light vs dark theming is stored in the html element's theme attribute (i.e., <html theme="dark"> or <html theme="light">).

However, the Sphinx Furo theme assumes that light vs dark theming is stored in the body element's data-theme attribute. As a result, if you use the Sphinx Furo theme for documentation and use Xarray HTML reprs, the Xarray HTML reprs do not display properly.

In truth, it seems that this comes down to the light vs dark theming not being standardized, which presents a problem of how to support multiple (possibly innumerable) different ways of specifying light or dark themes. That said, the Sphinx Furo theme has growing popularity, and I wonder if it could be supported as a special case (as is vscode dark themes).

To do this, one would need only modify one line of xarray/static/css/style.css:

https://github.com/pydata/xarray/blob/0db3440626721f8cdaf2f3e677d165061e870e26/xarray/static/css/style.css#L16-L17

to:

css html[theme=dark], body[data-theme=dark], body.vscode-dark {

If this is something that the Xarray community would support, I'm happy to put together a PR to do this.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6500/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed 13221727 issue

Links from other tables