issues: 1086346755
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1086346755 | PR_kwDOAMm_X84wKOjC | 6096 | Replace distutils.version with packaging.version | 10194086 | closed | 0 | 9 | 2021-12-22T00:51:21Z | 2023-01-20T21:00:42Z | 2021-12-24T14:50:48Z | MEMBER | 0 | pydata/xarray/pulls/6096 |
One change is that it is no longer possible to compare to a string, i.e. As mentioned in #6092 there are 3 options - if there is a preference I am happy to update this PR. ```python from distutils.version import LooseVersion from packaging import version LooseVersion(xr.version) version.parse(xr.version) version.Version(xr.version) currently:if LooseVersion(mod.version) < LooseVersion(minversion): pass options:if version.parse(mod.version) < version.parse(minversion): pass if version.Version(mod.version) < version.Version(minversion): pass if Version(mod.version) < Version(minversion): pass ``` |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/6096/reactions", "total_count": 3, "+1": 3, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |