issues: 1068680815

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1068680815 PR_kwDOAMm_X84vQ2hE 6037 Fix wrong typing for tolerance in reindex 57914115 closed 0     6 2021-12-01T17:19:08Z 2022-01-15T17:28:08Z 2022-01-15T17:27:56Z CONTRIBUTOR   0 pydata/xarray/pulls/6037

In the xarray.core.dataset.pymodule, more particulary in the reindex method the tolerance argument is set to be a Number

https://github.com/pydata/xarray/blob/f08672847abec18f46df75e2f620646d27fa41a2/xarray/core/dataset.py#L2743

But the _reindex function call reindex_variable function. In the reindex_variable the type for tolerance is Any. This function ends to call get_indexer_nd which call the pandas function get_indexer :

https://github.com/pydata/xarray/blob/f08672847abec18f46df75e2f620646d27fa41a2/xarray/core/indexes.py#L137

In pandas the type of tolerance according to the docs can be a scalar or a list-like object

  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6037/reactions",
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 2,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables