issues: 1061430200

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1061430200 PR_kwDOAMm_X84u6iop 6019 Use complex nan by default when interpolating out of bounds 1005109 closed 0     0 2021-11-23T15:38:25Z 2021-11-28T04:40:06Z 2021-11-28T04:40:06Z CONTRIBUTOR   0 pydata/xarray/pulls/6019
  • [X] Tests added
  • [X] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

When using the da.interp to interpolate outside of the bounds, by default, fill_value is set to np.nan to set the values to NaN. This is completely fine with real values, but with complex values this will in fact set the values to np.nan + 0j which can be a source of confusion and bugs. This PR propose to detect if values are complex, and if so, to use np.nan + np.nan*1j as the default fill_value

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6019/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables