id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 1478060173,I_kwDOAMm_X85YGWiN,7362,`xr.where()` with numpy inputs produces error if global options changed,38434768,closed,0,,,4,2022-12-06T03:17:55Z,2022-12-10T21:52:38Z,2022-12-10T21:52:38Z,NONE,,,,"### What happened? https://github.com/pydata/xarray/pull/7229 seems to have introduced a possibility for errors if the `set_options(keep_attrs=True)` is used and then subsequently `xr.where()` is called using numpy inputs ### What did you expect to happen? Previous to xarray v2022.12.0, this did not occur. `xr.where` should have a check for non-Dataset inputs before trying to access `attrs` ### Minimal Complete Verifiable Example ```Python >>> import xarray as xr >>> import numpy as np >>> xr.set_options(keep_attrs=True) >>> a = np.arange(10) >>> b = np.arange(15,25) >>> b = xr.where(a < 5, a, b) Traceback (most recent call last): File """", line 1, in File ""/Users/anissaz/opt/miniconda3/envs/geocat_comp_build/lib/python3.10/site-packages/xarray/core/computation.py"", line 1887, in where result.attrs = getattr(x, ""attrs"", {}) AttributeError: 'numpy.ndarray' object has no attribute 'attrs' ``` ### MVCE confirmation - [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray. - [X] Complete example — the example is self-contained, including all data and the text of any traceback. - [X] Verifiable example — the example copy & pastes into an IPython prompt or [Binder notebook](https://mybinder.org/v2/gh/pydata/xarray/main?urlpath=lab/tree/doc/examples/blank_template.ipynb), returning the result. - [X] New issue — a search of GitHub Issues suggests this is not a duplicate. ### Relevant log output _No response_ ### Anything else we need to know? Discovered via https://github.com/NCAR/geocat-comp/issues/308 ### Environment
INSTALLED VERSIONS ------------------ commit: None python: 3.10.6 | packaged by conda-forge | (main, Aug 22 2022, 20:41:54) [Clang 13.0.1 ] python-bits: 64 OS: Darwin OS-release: 21.6.0 machine: x86_64 processor: i386 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.12.2 libnetcdf: 4.8.1 xarray: 2022.12.0 pandas: 1.5.1 numpy: 1.23.5 scipy: 1.9.3 netCDF4: 1.6.2 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.6.2 nc_time_axis: None PseudoNetCDF: None rasterio: None cfgrib: None iris: None bottleneck: 1.3.5 dask: 2022.10.0 distributed: 2022.10.0 matplotlib: 3.6.1 cartopy: 0.21.0 seaborn: None numbagg: None fsspec: 2022.10.0 cupy: None pint: 0.19.2 sparse: None flox: None numpy_groupies: None setuptools: 65.5.0 pip: 22.3 conda: None pytest: 7.2.0 mypy: None IPython: None sphinx: None
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7362/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue