id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 1772050173,PR_kwDOAMm_X85Tx5fD,7938, fixing rolling_window issue with cupy,17344536,closed,0,,,4,2023-06-23T19:57:19Z,2023-06-23T21:07:45Z,2023-06-23T21:07:42Z,CONTRIBUTOR,,0,pydata/xarray/pulls/7938," - [x] Closes #7890. - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` * Relevant Cupy PR: https://github.com/cupy/cupy/pull/7575 ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7938/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1738835134,I_kwDOAMm_X85npIS-,7890,`xarray.rolling_window` Converts `dims` Argument from Tuple to List Causing Issues for Cupy-Xarray,17344536,closed,0,,,6,2023-06-02T21:16:01Z,2023-06-23T21:07:44Z,2023-06-23T21:07:44Z,CONTRIBUTOR,,,,"### What is your issue? Hello, I'm currently working on the development of cupy_xarray, and I've come across an issue with `xarray.rolling_window`. Specifically, it seems that the `dims` argument gets automatically converted to a list from a tuple. While numpy.normalize_axis_tuple can handle lists, thereby not raising errors when using numpy-backed xarray objects, its cupy equivalent (cupy.core.internal._normalize_axis_indices) does not. When a list is passed, it raises the following error: ``` File cupy/core/internal.pyx:424, in cupy.core.internal._normalize_axis_indices() TypeError: 'list' object cannot be interpreted as an integer. ``` It seems the line that might fix this is L2487: https://github.com/pydata/xarray/blob/c9d89e2b51b6dfee34e371a9232024ec45cd2d9c/xarray/core/variable.py#L2487-L2494 For the time being, we've managed to devise a workaround in cupy, but I thought it would be worthwhile to bring this to your attention. Relevant Cupy PR: https://github.com/cupy/cupy/pull/7575 Contributor: @dcherian ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7890/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue