id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 497416198,MDExOlB1bGxSZXF1ZXN0MzIwNTUxODg0,3336,Provide better error message when dimension name matches argument,2818208,open,0,,,7,2019-09-24T02:16:05Z,2023-12-02T02:53:11Z,,CONTRIBUTOR,,0,pydata/xarray/pulls/3336,"WIP PR for https://github.com/pydata/xarray/issues/3324. Since `either_dict_or_kwargs` is called 57 times, I don't want to modify every function call without a preliminary review. My main question is if using `locals()` at the top of each function is considered acceptable. Of course, if `locals()` is called _after_ some local variables are created, this code could raise an error when no conflict exists. But explicitly passing in the function argument names in all 57 functions seems brittle. I'd appreciate any thoughts on the PR before I modify all the functions and write some tests.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3336/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 499807676,MDExOlB1bGxSZXF1ZXN0MzIyNDM3NDI5,3352,Add glossary to documentation,2818208,closed,0,,,6,2019-09-28T18:45:40Z,2019-09-30T01:16:49Z,2019-09-29T23:39:54Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3352,"This is my attempt at closing https://github.com/pydata/xarray/issues/2410. I've borrowed a bit of text from that PR (thanks @horta), from https://github.com/pydata/xarray/issues/1295, and from the xarray docs. I avoided verbose examples—it makes quickly searching and reading the glossary difficult—and put most of the effort into explaining dimension vs non-dimension coordinates, which in my experience opens the door to true xarray enlightenment. Corrections, comments, or suggestions for additional terminology welcome.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3352/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 499811729,MDExOlB1bGxSZXF1ZXN0MzIyNDQwMzk1,3353,Remove `complex.nc` from built docs,2818208,closed,0,,,1,2019-09-28T19:23:10Z,2019-09-28T19:57:37Z,2019-09-28T19:57:37Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3353,"I assume this is related to https://github.com/pydata/xarray/issues/3297 or an associated issue. Basically, a file, `complex.nc`, is being added to `doc/` after running `make clean && make html`. Would be nice to suppress this. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3353/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 486079784,MDExOlB1bGxSZXF1ZXN0MzExNjA1NzA4,3270,Amend documentation to clean up temporary files/directories in examples,2818208,closed,0,,,1,2019-08-27T23:16:55Z,2019-08-28T00:02:05Z,2019-08-28T00:02:02Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3270," - [x] Closes #3227. - [x] No CI tests added, but I ran `make clean` and `make html` to confirm the temporary files are no longer permanently created. I also confirmed the `:suppress:` blocks weren't showing up in the built HTML. - [x] No need to pass `black . && mypy . && flake8`. - [x] Fully documented in `whats-new.rst`. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3270/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 482561245,MDExOlB1bGxSZXF1ZXN0MzA4ODEwMDc2,3233,Drop keyword support: small fixes,2818208,closed,0,,,4,2019-08-19T22:40:34Z,2019-08-23T22:05:39Z,2019-08-23T21:26:22Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3233," - Addresses issue https://github.com/pydata/xarray/issues/2910 and completes PR https://github.com/pydata/xarray/pull/3128. - Passes `black .` and `flake8`. - Documented in `whats-new.rst` and `indexing.rst`.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3233/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 484136116,MDExOlB1bGxSZXF1ZXN0MzEwMDc4MTYy,3243,Support for dict-like arguments for assign_coords,2818208,closed,0,,,1,2019-08-22T18:05:19Z,2019-08-22T18:35:59Z,2019-08-22T18:35:52Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3243," - [x] Closes https://github.com/pydata/xarray/issues/3231. - [x] Added tests for `Dataset` and `groupby`. Do we also need tests for `DataArray`? I assumed not since the actual code is in `common.py`, but I can add more. - [x] Passes `black . && mypy . && flake8`. - [x] Fully documented, including `whats-new.rst` and new example in the docstring.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3243/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 482143986,MDExOlB1bGxSZXF1ZXN0MzA4NDc0Mzcx,3228,Add examples of set_index and provide more clear error message,2818208,closed,0,,,1,2019-08-19T07:13:21Z,2019-08-19T16:02:54Z,2019-08-19T16:02:53Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3228,"- [x] Closes #3176 by adding examples of `set_index` and raising an error with a more clear error message. - [x] Added unit test for error message. - [x] Passes `black . ` and `flake8`. - [x] Documented in `whats-new.rst`.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3228/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 467856527,MDExOlB1bGxSZXF1ZXN0Mjk3NDA4MzQx,3126,Return immutable view of Pandas indexes,2818208,closed,0,,,9,2019-07-14T16:02:43Z,2019-08-19T07:33:46Z,2019-08-19T07:33:46Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3126,"- This closes #2949. We return a shallow copy of Pandas indexes to ensure immutability. - Added `test_index_immutability` in `tests/test_dataarray.py`. - Amended `whats-new.rst`.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3126/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 467865659,MDExOlB1bGxSZXF1ZXN0Mjk3NDE0NjY0,3128,Support keyword API for `Dataset.drop`,2818208,closed,0,,,20,2019-07-14T17:36:03Z,2019-08-19T02:24:00Z,2019-08-18T17:42:45Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3128,"- Closes https://github.com/pydata/xarray/issues/2910. - In `tests/test_dataset`, added `test_drop_labels_by_keyword` - Added a utility function `is_list_like`. - Documented in `whats-new.rst` and confirmed API docs built correctly.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3128/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 481935553,MDExOlB1bGxSZXF1ZXN0MzA4MzI0ODM1,3226,Add PR checklist to contributing docs,2818208,closed,0,,,3,2019-08-17T23:22:49Z,2019-08-18T17:49:24Z,2019-08-18T17:40:30Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3226,"I'm a new contributor working on a couple PRs for Xarray and wished I had a short checklist of things to do before pushing a commit. First, I think such an overview list is useful per se. Second, CI takes a while, and it's much faster to just run `black .` or to build the docs manually than it is easy wait for CI to fail. Inspired by [Scikit-learn's checklist](https://scikit-learn.org/stable/developers/contributing.html#pull-request-checklist). This is just a first draft; happy for suggestions or to add anything I'm missing.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3226/reactions"", ""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull