id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 1309966595,PR_kwDOAMm_X847rKxS,6812,Improved CF decoding,145117,open,0,,,7,2022-07-19T19:44:27Z,2023-04-01T15:26:04Z,,CONTRIBUTOR,,0,pydata/xarray/pulls/6812," - [X] Closes #2304 - but only for my specific use case. - [x] Tests added The comments above this line state, ""so we just use a float64"" but then it returns `np.float32`. I assume the comments are correct. Changing this also fixes a bug I ran into. Note that currently, `_choose_float_dtype` returns `float32` if the data is float16 or float32, even if the `scale_factor` dtype is float64.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6812/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1568970352,PR_kwDOAMm_X85JKJls,7499,Make text match code example,145117,closed,0,,,1,2023-02-03T00:21:02Z,2023-02-03T00:47:14Z,2023-02-03T00:47:14Z,CONTRIBUTOR,,0,pydata/xarray/pulls/7499," - [ ] Closes #xxxx - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7499/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1322645651,PR_kwDOAMm_X848Vs5i,6851,"Fix logic bug - add_offset is in encoding, not attrs.",145117,closed,0,,,3,2022-07-29T20:21:47Z,2022-08-01T18:07:04Z,2022-08-01T18:07:04Z,CONTRIBUTOR,,0,pydata/xarray/pulls/6851,"`_pop_to` does a pop operation - it removes the key/value pair. So the line above this change will remove `add_offset` from `attrs` if it exists. The second line then checks for `add_offset` in `attrs` which should always be `False`. This is implemented in #6812 but the work there is significantly more involved (see for example different PR addressing the same problem, #2304), so I'm pulling this fix out and submitting it as its own PR.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6851/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull